Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #2149 to fix the Eio backend of
irmin-fs.unix
:Conf
as this is the least invasive solution that we found... The main issue is thatirmin-cli
expects to be able to deserialize the conf values from the command-line / config file: the underhanded solution to this is to parametrize the confSpec
by the required eio capabilities. Cons: we technically loose spec uniqueness per backend, but this didn't seem to be used anyway other than for sanity checking irmin?WDYT of renaming
irmin-fs.unix
toirmin-fs.eio
?