Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-fs: Eio backend #2316

Open
wants to merge 1 commit into
base: eio
Choose a base branch
from
Open

irmin-fs: Eio backend #2316

wants to merge 1 commit into from

Conversation

art-w
Copy link
Contributor

@art-w art-w commented May 14, 2024

Follow-up on #2149 to fix the Eio backend of irmin-fs.unix:

  • The effects to access the eio capabilities had to go, as they break as soon as we spawn fibers which will escape the handler scope
  • Rather, the eio capabilities are passed through the irmin Conf as this is the least invasive solution that we found... The main issue is that irmin-cli expects to be able to deserialize the conf values from the command-line / config file: the underhanded solution to this is to parametrize the conf Spec by the required eio capabilities. Cons: we technically loose spec uniqueness per backend, but this didn't seem to be used anyway other than for sanity checking irmin?

WDYT of renaming irmin-fs.unix to irmin-fs.eio?

@art-w art-w requested a review from clecat May 14, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant