Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option and environment variable to specify S3 endpoint URL #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdidion
Copy link

@jdidion jdidion commented Sep 1, 2022

This addresses #14. It adds a command line option to the uploader (--s3endpoint) to specify an alternative endpoint, and defaults to the value of an environment variable (MINIWDL__AWS__S3_ENDPOINT_URL). If specified, the endpoint is specified as the value of the aws CLI --endpoint-url option.

@mlin
Copy link
Contributor

mlin commented Sep 5, 2022

LGTM modulo running the formatter (pre-commit run --all-files). I think this will work with AGC by adding ---s3endpoint to engineOptions in the workflow MANIFEST.json (but we won't know for sure until trying it at some undetermined future point when they pull in a new version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants