Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header for lifecycle config expiry to ignore replication #1999

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Sep 12, 2024

No description provided.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't bucket replication configuration a better place where we put this config ?

@poornas
Copy link
Contributor Author

poornas commented Sep 15, 2024

Isn't bucket replication configuration a better place where we put this config ?

this setting is for ILM to expire unreplicated versions or not - it belongs here

constants.go Show resolved Hide resolved
pkg/lifecycle/lifecycle.go Outdated Show resolved Hide resolved
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand. Why are we sending a config value as a header?

pkg/lifecycle/lifecycle.go Outdated Show resolved Hide resolved
@@ -127,4 +127,7 @@ const (
minioTgtReplicationReady = "X-Minio-Replication-Ready"
// Header asks if delete marker replication request can be sent by source now.
isMinioTgtReplicationReady = "X-Minio-Check-Replication-Ready"

// Header indicating if ilm expiry ignores replication status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header indicates if ILM expiration must trigger after replication

@harshavardhana
Copy link
Member

PTAL @vadmeste @krisis @klauspost

@harshavardhana harshavardhana merged commit 2a9a820 into minio:master Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants