Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add us-gov-east-1 FIPS GovCloud endpoint #1879

Closed
wants to merge 2 commits into from
Closed

Add us-gov-east-1 FIPS GovCloud endpoint #1879

wants to merge 2 commits into from

Conversation

sam-mcbr
Copy link

fixes #1878

@klauspost
Copy link
Contributor 

=== RUN   TestGetRegionFromURL
Error:     utils_test.go:139: Test 8: Expected region us-gov-east-1, got us-gov-west-1

@mehta-ankit mehta-ankit mentioned this pull request Aug 23, 2023
Closed
@harshavardhana
Copy link
Member

this PR is not sufficient and it is adding more hacks. Let me send a proper PR here closing.

@sam-mcbr sam-mcbr deleted the gov-fips-east branch August 23, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@klauspost klauspost Awaiting requested review from klauspost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing us-gov-east-1 region for FIPS endpoint
3 participants
@sam-mcbr @klauspost @harshavardhana