This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Add pattern filter to yml and check for valid links w/o opening files #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit adds a Rules field to the .yml file, and a Filter field under it to exclude unwanted patterns from the markdown content fetched from Github. - This commit also checks if the links are valid or not without opening the file. This change was done to improve performance by preventing the 'reveal' method from running for each document while the sidebar is being generated. - When the first link in the list of Documents is broken, to avoid the wrong link to be highlighted on index.html, Gluegun now returns an error while generating the index page and asks the user to correct it.
deekoder
reviewed
Apr 24, 2018
| @@ -171,6 +182,40 @@ def self.get_github_link(link) | |||
| return link | |||
| end | |||
|
|
|||
| def self.is_link_valid(link) | |||
There was a problem hiding this comment.
We can also use a gem to do this. Or do it ourselves.
deekoder
approved these changes
Apr 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under it to exclude unwanted patterns from the markdown content
fetched from Github.
the file. This change was done to improve performance by preventing the
'reveal' method from running for each document while the sidebar is
being generated.
wrong link to be highlighted on index.html, Gluegun now returns an error
while generating the index page and asks the user to correct it.