Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ACL policy grants #60

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

implement ACL policy grants #60

wants to merge 11 commits into from

Conversation

treksler
Copy link

@treksler treksler commented Jun 2, 2022

No description provided.

@treksler treksler requested review from mariux and a team as code owners June 2, 2022 20:04
@mariux
Copy link
Member

mariux commented Jun 3, 2022

thank you for your contribution.. the team will look into it asap.. ;) looks very good on first sight 👍

zied-elouaer
zied-elouaer reviewed Jun 17, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@zied-elouaer
Copy link

A few missing things:

  • Document the new variable grants
  • Add the new variable to the unit tests
  • Make sure README.md is generated from README.tfdoc.hcl using terradoc.

@treksler
Copy link
Author

treksler commented Oct 6, 2022

i gave it a shot to address the missing things

  • wasn't really sure what to add to the unit tests. I just added a grants block to one of the examples
  • hopefully the documentation changes are what you require

@zied-elouaer zied-elouaer self-requested a review October 14, 2022 15:55
@treksler
Copy link
Author

the only errors in https://github.com/mineiros-io/terraform-aws-s3-bucket/actions/runs/3198717372/jobs/5336038710 seem to be around "dead" links, which aren't actually dead

@zied-elouaer zied-elouaer removed their request for review December 29, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zied-elouaer zied-elouaer zied-elouaer left review comments

@mariux mariux Awaiting requested review from mariux mariux is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treksler @mariux @zied-elouaer