Compatibility with Ruby 3 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace File.exists? with File.exist? Update rubyzip Version bump to 2.0 because of the breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.exists?was deprecated in Ruby 2.2.0 and removed sometime after. This project contains a few uses and the pinned version ofrubyzipdoes as well. This replaces those instances and updatesrubyzipfor compatibility with Ruby 2.2.0 and later.I took the liberty of bumping the major version since these changes will not be backwards compatible with projects that currently use this gem. Happy to specify a different version number compatible with the maintainers wishes.
Changes