Datasource cleanup: introduce some types and avoid pass-by-context #5317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #5094, I discovered that there was some over-use of
any
and reflection that (IMO) made the code harder to understand. This hopefully contributes to polishing datasources for release.Change Type
Mark the type of change your PR introduces:
Testing
Tested with
go test
, which was helpful for finding all the places where signatures changed. Otherwise, this should be a no-op.Review Checklist: