Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource cleanup: introduce some types and avoid pass-by-context #5317

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

evankanderson
Copy link
Member

Summary

While working on #5094, I discovered that there was some over-use of any and reflection that (IMO) made the code harder to understand. This hopefully contributes to polishing datasources for release.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Tested with go test, which was helpful for finding all the places where signatures changed. Otherwise, this should be a no-op.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner January 16, 2025 23:01
Copy link
Contributor

@teodor-yanev teodor-yanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evankanderson evankanderson merged commit 1a425a6 into mindersec:main Jan 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants