Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options reading in history purge command. #5243

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jan 2, 2025

Summary

The added code makes it easier to read CLI options. It's probably a good idea to refactor that in a function wrapper.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

The added code makes it easier to read CLI options. It's probably a
good idea to refactor that in a function wrapper.
@blkt blkt self-assigned this Jan 2, 2025
@blkt blkt requested a review from a team as a code owner January 2, 2025 19:08
@blkt blkt merged commit de9b376 into main Jan 3, 2025
26 checks passed
@blkt blkt deleted the fix/fix-history-purge-options branch January 3, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants