Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate project and entity information to rule evaluation logs #4818

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

evankanderson
Copy link
Member

Summary

Currently, mostly of the rule evaluation logs don't include information about things like project_id or entity_id, which makes it hard to find specific error logs about a particular instance. We do have a single log message that indicates that the rule evaluation is started, but then a bunch of logs happen that don't clearly link back to the entity evaluation - started message.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual only, sorry!

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson
Copy link
Member Author

Sorry about that, I had some other code changes in flight, and apparently had an incorrect earlier version of the code committed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11503959131

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 54.096%

Files with Coverage Reduction New Missed Lines %
internal/eea/eea.go 2 73.73%
Totals Coverage Status
Change from base Build 11501586490: 0.009%
Covered Lines: 14211
Relevant Lines: 26270

💛 - Coveralls

@evankanderson evankanderson merged commit c8678a1 into mindersec:main Oct 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants