Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getting a logger from config to the config package #4816

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Oct 24, 2024

Summary

The following PR moves the function for getting a logger from the logging config to the config package.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner October 24, 2024 11:33
@rdimitrov rdimitrov self-assigned this Oct 24, 2024
JAORMX
JAORMX previously approved these changes Oct 24, 2024
Signed-off-by: Radoslav Dimitrov <[email protected]>
@rdimitrov rdimitrov merged commit f27c512 into main Oct 24, 2024
22 of 23 checks passed
@rdimitrov rdimitrov deleted the move-server-logger branch October 24, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants