Move events from internal to pkg

[rdimitrov]

Summary

The following PR moves events from internal to pkg

Change Type

Mark the type of change your PR introduces:

• Bug fix (resolves an issue without affecting existing features)
• Feature (adds new functionality without breaking changes)
• Breaking change (may impact existing functionalities or require documentation updates)
• Documentation (updates or additions to documentation)
• Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

• Reviewed my own code for quality and clarity.
• Added comments to complex or tricky code sections.
• Updated any affected documentation.
• Included tests that validate the fix or feature.
• Checked that related changes are merged.

[JAORMX]

IMO we should move constructors and interfaces to pkg. But not the whole implementation.

[evankanderson]

Can we defer this until after #4784 ?

[rdimitrov]

Can we defer this until after #4784 ?

Of course 👍 Do you have any idea how much time you'll need?

[evankanderson]

I'm guessing not more than 2-3 days

…

On Thu, Oct 24, 2024 at 7:03 AM Radoslav Dimitrov ***@***.***> wrote: Can we defer this until after #4784 <#4784> ? Of course 👍 Do you have any idea how much time you'll need? — Reply to this email directly, view it on GitHub <#4812 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4XEN7QMAKGFRY3IQVBHADZ5D42XAVCNFSM6AAAAABQQVCIMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGM4DMNZUHA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[coveralls]

Pull Request Test Coverage Report for Build 11515474144

Details

• 54 of 84 (64.29%) changed or added relevant lines in 27 files are covered.
• 3 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.006%) to 52.936%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/email/awsses/awsses.go	0	1	0.0%
internal/email/noop/noop.go	0	1	0.0%
internal/entities/handlers/handler.go	14	15	93.33%
internal/events/stubs/eventer.go	0	1	0.0%
internal/providers/github/installations/installations.go	0	1	0.0%
internal/providers/gitlab/manager/webhook_handlers_repos.go	0	1	0.0%
internal/reminder/reminder.go	0	1	0.0%
internal/engine/handler.go	1	3	33.33%
internal/service/service.go	0	2	0.0%
internal/providers/gitlab/manager/webhook_handlers_merge_requests.go	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
internal/reconcilers/reconcilers.go	1	60.0%
internal/engine/handler.go	1	73.08%
internal/reminderprocessor/reminder_processor.go	1	0.0%

Totals
Change from base Build 11514176926:	0.006%
Covered Lines:	13298
Relevant Lines:	25121

---

💛 - Coveralls

[jhrozek]

The newly exported interface looks minimal enough. I tried merging @evankanderson 's branch atop this one and while there were conflicts, they could be resolved quite easily (rename of events.Setup to eventer.New)