Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move profiles from internal to pkg #4811

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Move profiles from internal to pkg #4811

merged 1 commit into from
Oct 25, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR moves profiles from internal to pkg

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov self-assigned this Oct 24, 2024
@rdimitrov rdimitrov requested a review from a team as a code owner October 24, 2024 09:33
@evankanderson
Copy link
Member

It looks like this needs a rebase

evankanderson
evankanderson previously approved these changes Oct 24, 2024
Signed-off-by: Radoslav Dimitrov <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11513895937

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 52.938%

Totals Coverage Status
Change from base Build 11513788206: -1.2%
Covered Lines: 13297
Relevant Lines: 25118

💛 - Coveralls

@rdimitrov rdimitrov merged commit 2f4770a into main Oct 25, 2024
24 of 25 checks passed
@rdimitrov rdimitrov deleted the move-profiles branch October 25, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants