Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move util from internal to pkg #4809

Closed
wants to merge 1 commit into from
Closed

Move util from internal to pkg #4809

wants to merge 1 commit into from

Conversation

rdimitrov
Copy link
Member

Summary

The following PR moves util from internal to pkg

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner October 24, 2024 09:21
@rdimitrov rdimitrov self-assigned this Oct 24, 2024
Signed-off-by: Radoslav Dimitrov <[email protected]>
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead identify what specific pieces of util we need to make public and put that in relevant packages? Having a big util package is an antipattern anyway.

@rdimitrov rdimitrov closed this Oct 24, 2024
@rdimitrov rdimitrov deleted the move-util branch October 24, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants