Change defaults for pull request rules #4773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had previously added a function that defaulted the rule configuration if it was empty, in order to make the experience smoother for the UI user.
Since then, the UI has made a change that doesn't send an empty configuration by default, and instead sets some of the fields.
This change ensures that any fields that are unset get a default value.
We should consider moving default values to the rule schema itself, and marking the field as required, but that will be done as part of a larger rule validation epic.
Fixes mindersec/minder-rules-and-profiles#184
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: