Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display request ids in the CLI. #4763

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Display request ids in the CLI. #4763

merged 1 commit into from
Oct 17, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Oct 16, 2024

Summary

This change adds a -v/--verbose flag that causes Minder CLI to output request ids to standard error.

It's worth noticing that some commands (e.g. minder ruletype create and delete) issue multiple calls to Minder BE and thus output request ids multiple times.

Fixes #4612

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual testing.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This change adds a `-v/--verbose` flag that causes Minder CLI to
output request ids to standard error.

It's worth noticing that some commands (e.g. `minder ruletype create`
and `delete`) issue multiple calls to Minder BE and thus output
request ids multiple times.

Fixes #4612
@blkt blkt self-assigned this Oct 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11367835455

Details

  • 0 of 32 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 54.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/util/cli/cli.go 0 1 0.0%
internal/util/cli/rpc_client.go 0 31 0.0%
Files with Coverage Reduction New Missed Lines %
internal/eea/eea.go 2 73.73%
Totals Coverage Status
Change from base Build 11365222051: -0.06%
Covered Lines: 15034
Relevant Lines: 27440

💛 - Coveralls

@blkt blkt merged commit 89e17bf into main Oct 17, 2024
18 of 19 checks passed
@blkt blkt deleted the enh/request-id-cli branch October 17, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display request ids in the CLI
3 participants