Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reconciling of artifacts during repo reconciliation #4686

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Oct 8, 2024

Summary

The GitHub API doesn't allow us to list packages for repos, only for
organizations. We tried to work around that by listing packages for the
org and then filtering by the repository attribute, but this does not scale well.

Moreover, we agreed that going forward we'd like to register and enroll
packages in a similar way that we do register and enroll repositories.

Fixes: #4618

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

just made sure that repo register works.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

The GitHub API doesn't allow us to list packages for repos, only for
organizations. We tried to work around that by listing packages for the
org and then filtering by the repository attribute, but this does not scale well.

Moreover, we agreed that going forward we'd like to register and enroll
packages in a similar way that we do register and enroll repositories.

Fixes: mindersec#4618
@jhrozek jhrozek changed the title Remove reconciling of artifacts of repo reconciliation Remove reconciling of artifacts during repo reconciliation Oct 8, 2024
@jhrozek jhrozek merged commit adc8c8a into mindersec:main Oct 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace handleArtifactsReconcilerEvent with a more generic reconcile originating entities handler
2 participants