Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListEvaluationHistory now enforces max page size. #3873

Merged
merged 1 commit into from
Jul 12, 2024
Merged

ListEvaluationHistory now enforces max page size. #3873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/controlplane/handlers_evalstatus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ import (

const (
defaultPageSize uint64 = 25
// Maximum page size has a conservative value at the moment,
// we can raise it once we have more insight on its
// performance impact.
maxPageSize uint64 = 25
)

// ListEvaluationHistory lists current and past evaluation results for
Expand All @@ -63,6 +67,10 @@ func (s *Server) ListEvaluationHistory(
size = in.GetCursor().GetSize()
}

if size > maxPageSize {
return nil, status.Error(codes.InvalidArgument, "invalid cursor")
}

// process filter
opts := []history.FilterOpt{}
opts = append(opts, FilterOptsFromStrings(in.GetEntityType(), history.WithEntityType)...)
Expand Down