Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mindpak modules #2639

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Mindpak modules #2639

merged 4 commits into from
Mar 16, 2024

Conversation

puerco
Copy link
Contributor

@puerco puerco commented Mar 13, 2024

Summary

This PR converts the mindpak code to public packages in minder. This PR includes the Bundle and Packer code.

Fixes #2545

/cc @dmjb @JAORMX

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@puerco puerco requested a review from a team as a code owner March 13, 2024 20:37
@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 40.582%. remained the same
when pulling cec2ce6 on puerco:mindpak
into 9f0b994 on stacklok:main.

@puerco puerco force-pushed the mindpak branch 2 times, most recently from 7d54cf9 to cec2ce6 Compare March 13, 2024 21:06
JAORMX
JAORMX previously approved these changes Mar 15, 2024
dmjb
dmjb previously approved these changes Mar 15, 2024
puerco added 4 commits March 15, 2024 20:02
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit implements native go types of the mindpak bundle structs

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco puerco dismissed stale reviews from dmjb and JAORMX via 6a15a3d March 16, 2024 02:03
@JAORMX JAORMX merged commit 5cfbb07 into mindersec:main Mar 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create process/tooling for bundling healthcheck profile and rules into the proposed bundle structure
4 participants