Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make role grants add users to projects #2254

Closed
wants to merge 2 commits into from
Closed

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Feb 1, 2024

This adds the necessary code to ensure that a user belongs to a project
once it gets a role in it.

@JAORMX JAORMX requested a review from a team as a code owner February 1, 2024 13:07
@JAORMX JAORMX changed the title Make role grants add users to projects WIP: Make role grants add users to projects Feb 1, 2024
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just a small typo.
It is unfortunate that we need to keep this mapping in 2 places. Did you happen to look at what the impact would be if we remove the user_projects table and rely only on OpenFGA?

internal/authz/authz.go Outdated Show resolved Hide resolved
This adds the necessary code to ensure that a user belongs to a project
once it gets a role in it.
Co-authored-by: Eleftheria Stein-Kousathana <[email protected]>
@JAORMX
Copy link
Contributor Author

JAORMX commented Feb 1, 2024

@eleftherias I like the idea of relying more on OpenFGA to get projects for a user. I'll try it out in a separate PR.

@JAORMX
Copy link
Contributor Author

JAORMX commented Feb 1, 2024

Superseded by #2259

@JAORMX JAORMX closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants