Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout back to the original branch to reset the filesystem preventing ingest cache from corrupting #2160

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Vyom-Yadav
Copy link
Member

Fixes #2159


  • The initial approach was to copy the billy filesystem, but go-git internally restores the filesystem while checking out to different branches.
  • The ingested data would be technically modified after being cached, but the state of the originally fetched branch would be preserved.

…ng ingest cache from corrupting

* The filesystem is shared between remediator and evaluator. Checking out back to the original branch would allow evaluator to access filesystem on the correct branch

* The data is technically modified after being cached, but the state of the branch is preserved using git

Signed-off-by: Vyom-Yadav <[email protected]>
@Vyom-Yadav Vyom-Yadav requested a review from a team as a code owner January 21, 2024 13:13
@JAORMX JAORMX merged commit e6733eb into mindersec:main Jan 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared filesystem between remediator and evaluator corrupts the ingest cache
2 participants