Skip to content

Commit

Permalink
Removes unneeded Registered field
Browse files Browse the repository at this point in the history
The `Registered` field in `Repository` was not being used anywhere and given that `Repository` is only used to represent registered repositories, we should remove it.

Signed-off-by: ChrisJBurns <[email protected]>
  • Loading branch information
ChrisJBurns committed Jun 8, 2024
1 parent 75dcc45 commit 5ae6b4d
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 32 deletions.
1 change: 0 additions & 1 deletion docs/docs/ref/proto.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ require (
golang.org/x/oauth2 v0.21.0
golang.org/x/sync v0.7.0
golang.org/x/term v0.21.0
google.golang.org/genproto/googleapis/api v0.0.0-20240528184218-531527333157
google.golang.org/genproto/googleapis/api v0.0.0-20240604185151-ef581f913117
google.golang.org/grpc v1.64.0
google.golang.org/protobuf v1.34.1
gopkg.in/yaml.v2 v2.4.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1306,8 +1306,8 @@ google.golang.org/genproto v0.0.0-20200804131852-c06518451d9c/go.mod h1:FWY/as6D
google.golang.org/genproto v0.0.0-20200825200019-8632dd797987/go.mod h1:FWY/as6DDZQgahTzZj3fqbO1CbirC29ZNUFHwi0/+no=
google.golang.org/genproto v0.0.0-20240311173647-c811ad7063a7 h1:ImUcDPHjTrAqNhlOkSocDLfG9rrNHH7w7uoKWPaWZ8s=
google.golang.org/genproto v0.0.0-20240311173647-c811ad7063a7/go.mod h1:/3XmxOjePkvmKrHuBy4zNFw7IzxJXtAgdpXi8Ll990U=
google.golang.org/genproto/googleapis/api v0.0.0-20240528184218-531527333157 h1:7whR9kGa5LUwFtpLm2ArCEejtnxlGeLbAyjFY8sGNFw=
google.golang.org/genproto/googleapis/api v0.0.0-20240528184218-531527333157/go.mod h1:99sLkeliLXfdj2J75X3Ho+rrVCaJze0uwN7zDDkjPVU=
google.golang.org/genproto/googleapis/api v0.0.0-20240604185151-ef581f913117 h1:+rdxYoE3E5htTEWIe15GlN6IfvbURM//Jt0mmkmm6ZU=
google.golang.org/genproto/googleapis/api v0.0.0-20240604185151-ef581f913117/go.mod h1:OimBR/bc1wPO9iV4NC2bpyjy3VnAwZh5EBPQdtaE5oo=
google.golang.org/genproto/googleapis/rpc v0.0.0-20240528184218-531527333157 h1:Zy9XzmMEflZ/MAaA7vNcoebnRAld7FsPW1EeBB7V0m8=
google.golang.org/genproto/googleapis/rpc v0.0.0-20240528184218-531527333157/go.mod h1:EfXuqaE1J41VCDicxHzUDm+8rk+7ZdXzHV0IhO/I6s0=
google.golang.org/grpc v1.19.0/go.mod h1:mqu4LbDTu4XGKhr4mRzUsmM4RtVoemTSY81AxZiDr8c=
Expand Down
3 changes: 0 additions & 3 deletions pkg/api/openapi/minder/v1/minder.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 10 additions & 20 deletions pkg/api/protobuf/go/minder/v1/minder.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions proto/minder/v1/minder.proto
Original file line number Diff line number Diff line change
Expand Up @@ -965,11 +965,10 @@ message Repository {
string hook_uuid = 12;
bool is_private = 13;
bool is_fork = 14;
bool registered = 15;
google.protobuf.Timestamp created_at = 16;
google.protobuf.Timestamp updated_at = 17;
string default_branch = 18;
string license = 19;
google.protobuf.Timestamp created_at = 15;

Check failure on line 968 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "15" with name "created_at" on message "Repository" changed option "json_name" from "registered" to "createdAt".

Check failure on line 968 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "15" with name "created_at" on message "Repository" changed type from "bool" to "message". See https://developers.google.com/protocol-buffers/docs/proto3#updating for wire compatibility rules and https://developers.google.com/protocol-buffers/docs/proto3#json for JSON compatibility rules.

Check failure on line 968 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "15" on message "Repository" changed name from "registered" to "created_at".
google.protobuf.Timestamp updated_at = 16;

Check failure on line 969 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "16" with name "updated_at" on message "Repository" changed option "json_name" from "createdAt" to "updatedAt".

Check failure on line 969 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "16" on message "Repository" changed name from "created_at" to "updated_at".
string default_branch = 17;

Check failure on line 970 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "17" with name "default_branch" on message "Repository" changed option "json_name" from "updatedAt" to "defaultBranch".

Check failure on line 970 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "17" with name "default_branch" on message "Repository" changed type from "message" to "string". See https://developers.google.com/protocol-buffers/docs/proto3#updating for wire compatibility rules and https://developers.google.com/protocol-buffers/docs/proto3#json for JSON compatibility rules.

Check failure on line 970 in proto/minder/v1/minder.proto

View workflow job for this annotation

GitHub Actions / proto-breaking-changes

Field "17" on message "Repository" changed name from "updated_at" to "default_branch".
string license = 18;
}

message RegisterRepositoryRequest {
Expand Down

0 comments on commit 5ae6b4d

Please sign in to comment.