Populate project_id field on rule_instances (#3579)

Also sets project_id as not null

database/migrations/000068_rule_instance_project_id_migrate.down.sql

@@ -0,0 +1,15 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+ALTER TABLE rule_instances ALTER COLUMN project_id DROP NOT NULL;

database/migrations/000068_rule_instance_project_id_migrate.up.sql

@@ -0,0 +1,26 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+BEGIN;
+
+-- populate by joining on profiles table
+UPDATE rule_instances AS ri
+SET project_id = pf.project_id
+FROM profiles AS pf
+WHERE ri.profile_id = pf.id;
+
+-- now we can add the not null constraint
+ALTER TABLE rule_instances ALTER COLUMN project_id SET NOT NULL;
+
+COMMIT;

internal/profiles/service.go

@@ -778,10 +778,7 @@ func upsertRuleInstances(
 		id, err := qtx.UpsertRuleInstance(ctx, db.UpsertRuleInstanceParams{
 			ProfileID: profileID,
 			// TODO: Make non nullable in future PR
-			ProjectID: uuid.NullUUID{
-				UUID:  projectID,
-				Valid: true,
-			},
+			ProjectID:  projectID,
 			RuleTypeID: entityRuleTuple.RuleID,
 			Name:       rule.Name,
 			EntityType: entityType,