Exclude the action name only not the full uses in actions_check_pinned_tags #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_tags Our example profiles exclude just the action name because that's what frizbee uses internally to exclude: https://github.com/stacklok/minder-rules-and-profiles/blob/main/profiles/github/stacklok-health-check.yaml#L29 But the rego check in the actions_check_pinned_tags rule was excluding on the full value of uses. This meant that the remediation was always called even if it didn't produce anything and the exclude didn't work.
|
gonna reopen this from a branch from origin to make sure tests run |
JAORMX
requested changes
Apr 15, 2024
| # Split the uses directive at '@' | ||
| parts := split(s.uses, "@") | ||
|
|
||
| # Skip if the action name is part of excludes | ||
| not is_excluded(parts[0], input.profile.exclude) |
There was a problem hiding this comment.
Let's add an or statement checking the case where the tag is used in the excludes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our example profiles exclude just the action name because that's what
frizbee uses internally to exclude:
https://github.com/stacklok/minder-rules-and-profiles/blob/main/profiles/github/stacklok-health-check.yaml#L29
But the rego check in the actions_check_pinned_tags rule was excluding
on the full value of uses. This meant that the remediation was always
called even if it didn't produce anything and the exclude didn't work.