Minor ruletype descriptions #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of ruletype text updates I found while I was testing different ruletypes through UI - more ecosystem examples for the popular dependabot ecosystems - provide a reasonable default for codeQL schedule - say that minder will use builtin defaults for the OSV ruletype to make it clear that the user doesn't have to fill them in - fix description of exclude for the action pinning ruletype
jhrozek
commented
Apr 12, 2024
| @@ -38,7 +38,8 @@ def: | |||
| schedule_interval: | |||
| type: string | |||
| description: | | |||
| Only applicable for remediation. Sets the schedule interval for the workflow. | |||
| Sets the schedule interval in cron format for the workflow. Only applicable for remediation. | |||
| default: '30 * * * *' | |||
There was a problem hiding this comment.
I /think/ this should be safe because we don't actually enforce the defaults on the back end level, so the defaults would be kind of advisory use for FE.
JAORMX
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of ruletype text updates I found while I was testing different
ruletypes through UI
it clear that the user doesn't have to fill them in