Add OSPS Baseline Level 1 rules. #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
force-pushed
the
feat/add-baseline-profile-and-rules
branch
from
b3b647a to
50f2fb9
Compare
evankanderson
previously approved these changes
Jan 10, 2025
Comment on lines
1
to
7
| Apache License | ||
| Version 2.0, January 2004 | ||
| http://www.apache.org/licenses/ | ||
|
|
||
| TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION | ||
|
|
||
| ... |
There was a problem hiding this comment.
This shouldn't be a license file, this should say something like:
Suggested change
| Apache License | |
| Version 2.0, January 2004 | |
| http://www.apache.org/licenses/ | |
| TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION | |
| ... | |
| # Contributing to Foo | |
| We welcome contributions, and the rest of this doc is slap-dash! Sorry! |
There was a problem hiding this comment.
We're just checking for existence, not content.
I'm not sure we want to check contents as well, might be tricky.
...y-baseline/rule-types/github/osps-do-02.testdata/contributing_file_no_extension/CONTRIBUTING
Outdated
Show resolved
Hide resolved
security-baseline/rule-types/github/osps-do-02.testdata/contributing_folder/CONTRIBUTING/myfile
Outdated
Show resolved
Hide resolved
security-baseline/rule-types/github/osps-do-02.testdata/no_data/foo
Outdated
Show resolved
Hide resolved
Yes, sorry for the confusing branch name. |
blkt
force-pushed
the
feat/add-baseline-profile-and-rules
branch
from
9525df8 to
9fb924a
Compare
|
@evankanderson our good @teodor-yanev was quicker than I was and got the profile merged earlier today. |
This change adds all currently implemented rule types for OSPS Baseline Level 1. Some rules were copy-pasted from rules like e.g. `branch_protection_allow_deletions` in order to (a) be able to change them independently and (b) change the name to something descriptive in the scope of Security Baseline. We generally do not foster this, but in this case we deemed simplicity was preferable to avoiding duplication. Along the rules themselves, tests were added to new, existing ones, and their copies. Fixes stacklok/minder-stories#198
blkt
force-pushed
the
feat/add-baseline-profile-and-rules
branch
from
9fb924a to
ef919c5
Compare
evankanderson
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds all currently implemented rule types for OSPS Baseline Level 1.
Some rules were copy-pasted from rules like
e.g.
branch_protection_allow_deletionsin order to (a) be able to change them independently and (b) change the name to something descriptive in the scope of Security Baseline. We generally do not foster this, but in this case we deemed simplicity was preferable to avoiding duplication.Along the rules themselves, tests were added to new, existing ones, and their copies.
Fixes stacklok/minder-stories#198