Add the workflow_no_pull_request_target rule with tests #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
commented
Oct 22, 2024
| For more information, see [GitHub's | ||
| documentation](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target). | ||
| guidance: | | ||
| Ensure that GitHub Actions workflows do not use the pull_request_target event. |
There was a problem hiding this comment.
@eleftherias Would you mind checking if the descriptio, guidance and error reporting match what we expect rules to provide these days towards the UIs?
I admit I wasn't following your work on this lately. Don't feel like you need to review the code as well (unless you want to!)
There was a problem hiding this comment.
That all looks good @jhrozek
jhrozek
force-pushed
the
no_pull_request_target
branch
from
29941fc to
ad0ad94
Compare
|
@JAORMX Updated based on the changes in Minder. So far I tested with a local |
jhrozek
force-pushed
the
no_pull_request_target
branch
from
ad0ad94 to
19d0a2a
Compare
jhrozek
force-pushed
the
no_pull_request_target
branch
from
19d0a2a to
1bebdf9
Compare
Adds a ruletype that checks that a workflow does not use the `pull_request_target` trigger.
jhrozek
force-pushed
the
no_pull_request_target
branch
from
1bebdf9 to
a9614bc
Compare
|
Resubmitted without the tests until we have the harness that runs them merged. |
rdimitrov
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ruletype that checks that a workflow does not use the
pull_request_targettrigger.Depends on mindersec/minder#4793