Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tests for rule types #185

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Introduce tests for rule types #185

merged 6 commits into from
Oct 18, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 16, 2024

This uses Minder's testkit in order to create tests for rule types. A
sample is given for the license and secret_scanning_enabled rule
types.

Signed-off-by: Juan Antonio Osorio [email protected]

@JAORMX JAORMX marked this pull request as draft October 16, 2024 13:39
@JAORMX JAORMX force-pushed the testkit-tests branch 2 times, most recently from b89b54d to 487e793 Compare October 17, 2024 09:44
@JAORMX JAORMX marked this pull request as ready for review October 17, 2024 09:44
This uses Minder's testkit in order to create tests for rule types. A
sample is given for the `license` and `secret_scanning_enabled` rule
types.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
@rdimitrov rdimitrov self-requested a review October 17, 2024 18:33
@JAORMX JAORMX requested a review from jhrozek October 18, 2024 10:09
rules_test.go Outdated Show resolved Hide resolved
jhrozek
jhrozek previously approved these changes Oct 18, 2024
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to run and modifying the test data causes failures. I left a nit inline, but since this is test code, feel free to go ahead and merge.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX merged commit c0c086d into mindersec:main Oct 18, 2024
3 checks passed
blkt added a commit that referenced this pull request Oct 18, 2024
blkt added a commit that referenced this pull request Oct 18, 2024
JAORMX added a commit that referenced this pull request Oct 22, 2024
JAORMX added a commit that referenced this pull request Oct 22, 2024
rdimitrov added a commit that referenced this pull request Oct 22, 2024
rdimitrov added a commit that referenced this pull request Oct 22, 2024
jhrozek pushed a commit to jhrozek/minder-rules-and-profiles that referenced this pull request Oct 23, 2024
JAORMX added a commit that referenced this pull request Oct 23, 2024
rdimitrov added a commit that referenced this pull request Oct 24, 2024
blkt pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants