Update rule configuration #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The branch protection rules have a sensible default of the remote HEAD branch. As a result, they no longer _require_ the branch name. Right now, callers must specify the branch name as an empty string (since it's required), but we should instead just remove the requirement entirely.
The security insights rules have a sensible default of `SECURITY-INSIGHTS.yml`, thus, we should not require the filename.
The dependabot rule does not use the schedule_interval option; it should not be required any longer.
The security policy rule has a sensible default of `SECURITY.md`, thus, we should not require the filename.
rdimitrov
approved these changes
Oct 11, 2024
jhrozek
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of simplifications to rule configuration, removing required fields that are not actually required, since we have useful defaults.