Change the artifact_signature rule to use constraints evaluation, not deny-by-default #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deny-by-default Because the artifact_signature rule uses the deny-by-default model all we get from the evaluation in case it fails is denied. Especially for artifacts this is not ideal as we can't tell the user what changed in the artifact vs. the expected state unless they look at minder logs. Fixes: mindersec#103
|
Let's brainstorm about this tomorrow. |
JAORMX
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the artifact_signature rule uses the deny-by-default model all
we get from the evaluation in case it fails is denied. Especially for
artifacts this is not ideal as we can't tell the user what changed in
the artifact vs. the expected state unless they look at minder logs.
Fixes: #103