Skip to content

Commit

Permalink
Remove local web server & Carthage (#159)
Browse files Browse the repository at this point in the history
### Summary
Conduit CI has been broken for a long time (since March 2020): 
- Last successful cron build was [10 months ago](https://travis-ci.org/github/mindbody/Conduit/builds/667694645) 
- Last successful PR build was also [10 months ago](https://travis-ci.org/github/mindbody/Conduit/builds/667774882)

This is mainly because the local web-server used for unit and integration tests was outdated. As new versions of Ruby and Python have been released, and our systems and CI servers upgraded, the local server stopped running. Quite some good tech-debt we had queued.

### Implementation
- Remove local web servers
  - httpbin has been replaced with calls to https://httpbin.org (as we originally had). Video assets have been reduced in size for faster round-trips during testing.
  - oauth-test-server has been removed and not replaced (a handful of tests have been disabled for now)
- Project and workspace files have been removed to simplify the codebase and maintenance efforts.
- Carthage support has also been removed, might be added later as XCFramework if there is public demand.
- Travis CI has been removed
- GitHub Actions have been set up for CI
  • Loading branch information
eneko authored Feb 10, 2021
1 parent 12fe831 commit ea57578
Show file tree
Hide file tree
Showing 94 changed files with 102 additions and 6,461 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: CI

on:
push:
branches: [ main, release/* ]
pull_request:
branches: [ main, release/* ]

jobs:
build:
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- name: Build and Test
run: swift test

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 0 additions & 22 deletions .travis.yml

This file was deleted.

2 changes: 0 additions & 2 deletions Brewfile

This file was deleted.

9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@
- None


## 1.0.0

#### Breaking
- Remove Xcode project and worskpaces, dropping support for Carthage

#### Other
- Celebrating Conduit's maturity with our 1.0.0 release 🎉


## 0.22.0

#### Breaking
Expand Down
6 changes: 3 additions & 3 deletions Conduit.podspec
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$version = '0.22.0'
$version = '1.0.0'

Pod::Spec.new do |spec|
spec.name = 'Conduit'
Expand All @@ -12,8 +12,8 @@ Pod::Spec.new do |spec|
spec.ios.frameworks = 'Security', 'SystemConfiguration'
spec.tvos.frameworks = 'Security', 'SystemConfiguration'
spec.osx.frameworks = 'Security', 'SystemConfiguration'
spec.ios.deployment_target = '8.0'
spec.ios.deployment_target = '9.0'
spec.watchos.deployment_target = '2.0'
spec.tvos.deployment_target = '9.0'
spec.osx.deployment_target = '10.10'
spec.osx.deployment_target = '10.11'
end
3,819 changes: 0 additions & 3,819 deletions Conduit.xcodeproj/project.pbxproj

This file was deleted.

This file was deleted.

101 changes: 0 additions & 101 deletions Conduit.xcodeproj/xcshareddata/xcschemes/Conduit-iOS.xcscheme

This file was deleted.

101 changes: 0 additions & 101 deletions Conduit.xcodeproj/xcshareddata/xcschemes/Conduit-macOS.xcscheme

This file was deleted.

101 changes: 0 additions & 101 deletions Conduit.xcodeproj/xcshareddata/xcschemes/Conduit-tvOS.xcscheme

This file was deleted.

Loading

0 comments on commit ea57578

Please sign in to comment.