Cleaned up and improved middleware output (#76)

Minimal cleanup of verbose output for debugging purposes.
mindbody · Aug 30, 2018 · c25fa79 · c25fa79
1 parent 43fbc1c
commit c25fa79
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,7 @@
 - Allow direct manipulation of XML trees by converting XML and XMLNode from struct to class. 
 
 #### Enhancements
-- None
+- Improved verbose logging for middleware pipeline.
 
 #### Bug Fixes
 - None

diff --git a/Sources/Conduit/Networking/URLSessionClient.swift b/Sources/Conduit/Networking/URLSessionClient.swift
@@ -135,28 +135,22 @@ public struct URLSessionClient: URLSessionClientType {
 
         serialQueue.async {
 
-            // First, check if the queue needs to be evicted and frozen
-
-            logger.verbose("About to scan middlware options")
+            logger.verbose("Scanning middlware options ⌛︎")
 
             for middleware in self.requestMiddleware {
                 if middleware.pipelineBehaviorOptions.contains(.awaitsOutgoingCompletion) {
-                    logger.verbose("=============== WAIT ===============")
-                    logger.verbose("Pausing session queue")
-
+                    logger.verbose("Paused session queue ⏸")
                     _ = self.activeTaskQueueDispatchGroup.wait(timeout: DispatchTime.distantFuture)
-
-                    logger.verbose("Resuming session queue")
-                    logger.verbose("--------------- RESUME -------------")
+                    logger.verbose("Resumed session queue ▶️")
                 }
             }
 
-            logger.verbose("Finshed scanning middleware options")
+            logger.verbose("Finished scanning middleware options ✓")
 
             // Next, allow each middleware component to have its way with the original URLRequest
             // This is done synchronously on the serial queue since the pipeline itself shouldn't allow for concurrency
 
-            logger.verbose("About to process request through middleware pipeline")
+            logger.verbose("Processing request through middleware pipeline ⌛︎")
 
             let middlewareProcessingResult = self.synchronouslyPrepareForTransport(request: request)
 
@@ -176,7 +170,7 @@ public struct URLSessionClient: URLSessionClientType {
                 modifiedRequest = request
             }
 
-            logger.verbose("Finished processing request through middleware pipeline")
+            logger.verbose("Finished processing request through middleware pipeline ✓")
 
             // Finally, send the request
             // Once tasks are created, the operation moves to the connection queue,