Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

condense init parameters #16

Merged
merged 39 commits into from
Jul 4, 2024
Merged

condense init parameters #16

merged 39 commits into from
Jul 4, 2024

Conversation

tomMoral
Copy link
Collaborator

No description provided.

@tomMoral tomMoral mentioned this pull request May 30, 2024
Open
7 tasks
@vloison
Copy link
Collaborator

vloison commented May 31, 2024

Done:

  • Remove unused parameters in FaDIn init
  • Condense remaining parameters in FaDIn init
  • Update references to the FaDIn solver with new parameters
  • Create custom solvers FaDIn_no_precomputations and FaDIn_loglikelihood to reproduce FaDIn experiments -> I couldn't run the experiments as I don't have tick, @GuillaumeStaermanML or @tomMoral could you please check that they still run?
  • Add moment matching to FaDIn

tomMoral
tomMoral commented Jun 1, 2024
View reviewed changes
Copy link
Collaborator Author

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first round of reviews

experiments/benchmark/run_benchmark_exp.py Outdated Show resolved Hide resolved
fadin/solver.py Outdated Show resolved Hide resolved
fadin/solver.py Outdated Show resolved Hide resolved
fadin/utils/utils.py Outdated Show resolved Hide resolved
fadin/tests/test_loss_and_gradient.py Show resolved Hide resolved
fadin/solver.py Outdated Show resolved Hide resolved
fadin/solver.py Outdated Show resolved Hide resolved
fadin/loss_and_gradient.py Outdated Show resolved Hide resolved
vloison and others added 20 commits June 12, 2024 21:36
@vloison @tomMoral
Update experiments/benchmark/run_benchmark_exp.py
649c2db 
according to review

Co-authored-by: Thomas Moreau <[email protected]>
@vloison @tomMoral
Update fadin/solver.py
42cecfb 
according to review

Co-authored-by: Thomas Moreau <[email protected]>
@vloison @tomMoral
Update fadin/solver.py
bce234f 
All class names in CamelCase

Co-authored-by: Thomas Moreau <[email protected]>
@vloison
comment +1 in assert torch.isclose
cc1e10f
@vloison
Move FaDInLoglikelihood and FaDInNoPrecomputations to experiments
33bc14e
@vloison
clean imports
5c11fc7
@vloison
change optim_iteration to compute_gradient for clarity
2ce478a
@GuillaumeStaermanML
condensate unit parameters and precomputations
c8695c2
@GuillaumeStaermanML
condensate unit parameters and precomputations
4891015
@GuillaumeStaermanML
condensate unit parameters and precomputations
541e9f7
@GuillaumeStaermanML
condensate unit parameters and precomputations
c2fb1b5
@GuillaumeStaermanML
correct tests
fb942ec
@GuillaumeStaermanML
correct tests
94e4032
@GuillaumeStaermanML
remove tick from the simulation of experiments
562ebd8
@GuillaumeStaermanML
remove useless experiments and comparisons with tick
5ed638a
@GuillaumeStaermanML
useless files
68c5d89
@vloison
simplify init parameter of FaDIn and move Hawkes initialization to a …
9942b54 
…separate file
@vloison
Merge branch 'condense' of https://github.com/mind-inria/FaDIn
1ebd4e9
@vloison
replace solver.W with solver.kernel_length
5a453ff
@vloison
fix scipy.integrate.simps expired deprecation and linter
00db0a7
tomMoral
tomMoral commented Jul 1, 2024
View reviewed changes
fadin/init.py Outdated Show resolved Hide resolved
fadin/init.py Show resolved Hide resolved
fadin/init.py Show resolved Hide resolved
fadin/init.py Outdated Show resolved Hide resolved
fadin/init.py Outdated Show resolved Hide resolved
fadin/init.py Show resolved Hide resolved
fadin/init.py Outdated Show resolved Hide resolved
fadin/init.py Show resolved Hide resolved
fadin/solver.py Outdated Show resolved Hide resolved
tomMoral
tomMoral commented Jul 3, 2024
View reviewed changes
Copy link
Collaborator Author

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few extra comments, when taken into account, feel free to merge.

fadin/init.py Show resolved Hide resolved
fadin/solver.py Outdated Show resolved Hide resolved
fadin/solver.py Outdated Show resolved Hide resolved
fadin/init.py Show resolved Hide resolved
fadin/utils/utils.py Outdated Show resolved Hide resolved
@tomMoral tomMoral merged commit 780b3e0 into main Jul 4, 2024
8 checks passed
@tomMoral tomMoral deleted the condense branch July 4, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vloison vloison vloison left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomMoral @vloison @GuillaumeStaermanML