-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lock_height to Transaction and TxKernel #167
Conversation
sign msg including both fee and lock_height in kernel
working on fixing up those |
core/src/core/transaction.rs
Outdated
/// consistently across Transaction and TxKernel | ||
/// TODO - add some test coverage for this to make sure the bytes are in there | ||
/// correctly | ||
fn transaction_fee_and_lock_height_to_bytes(fee: u64, lock_height: u64) -> [u8; 32] { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Good in principle. I'm a little bummed we have to have another clear value in addition to fees but I don't have a better option for now. |
where tx is invalid based on current height of the blockchain
@ignopeverell any further feedback/thoughts on this? |
Looks good to me! |
Initial attempt at introducing "time locked" transactions.
TODO -
transaction_fee_and_lock_height_to_bytes
->kernel_sig_msg
lock_height
toTransaction
andTxKernel
fee
andlock_height
fee
andlock_height
against the signatureNote: this is similar to the
lock_height
on a coinbase output but not the same.This is a "timelock" on the tx/kernel itself, not an output.
See #25 for more info/context/discussion.