Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set deltalogs for stats task after set segment stating #39503

Closed
wants to merge 1 commit into from

Conversation

xiaocai2333
Copy link
Contributor

issue: #39333

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 22, 2025
@xiaocai2333
Copy link
Contributor Author

/hold
wait #39459 merged

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 22, 2025
Copy link
Contributor

mergify bot commented Jan 22, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 22, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (1a1ed07) to head (7788b42).
Report is 11 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1a1ed07) and HEAD (7788b42). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1a1ed07) HEAD (7788b42)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39503       +/-   ##
===========================================
- Coverage   81.00%   69.56%   -11.45%     
===========================================
  Files        1407      300     -1107     
  Lines      198705    26986   -171719     
===========================================
- Hits       160970    18773   -142197     
+ Misses      32074     8213    -23861     
+ Partials     5661        0     -5661     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.56% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)

see 1108 files with indirect coverage changes

czs007 pushed a commit that referenced this pull request Jan 22, 2025
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Jan 23, 2025
@xiaocai2333
Copy link
Contributor Author

/close
related: #39459

@sre-ci-robot
Copy link
Contributor

@xiaocai2333: Closed this PR.

In response to this:

/close
related: #39459

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. do-not-merge/hold kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants