Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] serializes the resp body and attach some details #39401

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

smellthemoon
Copy link
Contributor

issue: #37611
pr: #39140

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 17, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (f704e3e) to head (0b28843).
Report is 13 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39401       +/-   ##
===========================================
+ Coverage   69.49%   81.01%   +11.52%     
===========================================
  Files         300     1404     +1104     
  Lines       26767   197572   +170805     
===========================================
+ Hits        18601   160067   +141466     
- Misses       8166    31884    +23718     
- Partials        0     5621     +5621     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.49% <ø> (ø)
Go 82.98% <100.00%> (∅)
Files with missing lines Coverage Δ
...distributed/proxy/httpserver/timeout_middleware.go 79.09% <100.00%> (ø)

... and 1103 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 20, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smellthemoon, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e4c6ef9 into milvus-io:2.5 Jan 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants