Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct remote centroids path in clustering compaction #39398

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

chasingegg
Copy link
Contributor

issue: #39353
The path was modified unintentionally, change it back.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 17, 2025
@xiaocai2333
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (64feeb0) to head (06f45e6).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/clustering/KmeansClustering.h 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39398      +/-   ##
==========================================
- Coverage   81.01%   81.00%   -0.01%     
==========================================
  Files        1407     1408       +1     
  Lines      198528   198562      +34     
==========================================
+ Hits       160843   160853      +10     
- Misses      32029    32056      +27     
+ Partials     5656     5653       -3     
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.47% <0.00%> (-0.01%) ⬇️
Go 82.94% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/clustering/KmeansClustering.h 0.00% <0.00%> (ø)

... and 41 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2025
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Jan 20, 2025
@sre-ci-robot sre-ci-robot merged commit 1a680c2 into milvus-io:master Jan 20, 2025
17 of 20 checks passed
@chasingegg chasingegg deleted the fix-path branch January 20, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants