Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] clean up logs of empty op key #39394

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from master: #39335
related: #39334

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 17, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (0c00f94) to head (426489c).
Report is 2 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/rootcoord/rbac_task.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39394      +/-   ##
==========================================
- Coverage   81.03%   81.01%   -0.02%     
==========================================
  Files        1404     1404              
  Lines      197572   197573       +1     
==========================================
- Hits       160100   160064      -36     
- Misses      31862    31891      +29     
- Partials     5610     5618       +8     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.49% <ø> (ø)
Go 82.98% <50.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/rbac_task.go 70.03% <50.00%> (+0.10%) ⬆️

... and 27 files with indirect coverage changes

@shaoting-huang
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants