Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refine variable-length-type memory usage(#38736) #39393

Closed
wants to merge 5 commits into from
Closed

enhance: refine variable-length-type memory usage(#38736) #39393

wants to merge 5 commits into from

Conversation

MrPresent-Han
Copy link
Contributor

related: #38736

@sre-ci-robot sre-ci-robot added area/compilation size/XL Denotes a PR that changes 500-999 lines. labels Jan 17, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 17, 2025
@MrPresent-Han
Copy link
Contributor Author

/hold

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 20, 2025

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Jan 20, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 20, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 20, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 20, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

add log for string column
cd50d21 
Signed-off-by: MrPresent-Han <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
area/compilation do-not-merge/hold kind/enhancement Issues or changes related to enhancement needs-dco DCO is missing in this pull request. size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrPresent-Han @sre-ci-robot