fix: Skip load extra indexes for sorted segment pk field #39389
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#39339 Extra indexes can be ignored for most cases since sorted pk column already provided indexing features Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
@congqixia go-sdk check failed, comment |
|
rerun go-sdk |
Signed-off-by: Congqi Xia <[email protected]>
|
@congqixia go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39389 +/- ##
==========================================
+ Coverage 80.99% 81.03% +0.04%
==========================================
Files 1407 1407
Lines 198528 198532 +4
==========================================
+ Hits 160794 160886 +92
+ Misses 32063 31998 -65
+ Partials 5671 5648 -23
|
|
rerun go-sdk |
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 17, 2025
Cherry-pick from master pr: #39389 Related to #39339 Extra indexes can be ignored for most cases since sorted pk column already provided indexing features --------- Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #39339
Extra indexes can be ignored for most cases since sorted pk column already provided indexing features