Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rocksmq consumer register not concurrent safe #39387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jan 17, 2025

relate: #39336

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 17, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (bca2a62) to head (1ff83c9).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39387      +/-   ##
==========================================
- Coverage   69.63%   69.47%   -0.16%     
==========================================
  Files         299      300       +1     
  Lines       26807    26903      +96     
==========================================
+ Hits        18668    18692      +24     
- Misses       8139     8211      +72     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.47% <ø> (-0.16%) ⬇️
Go ∅ <ø> (∅)

see 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants