Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip init/release wal accesser if streaming service disabled #39368

Closed

Conversation

weiliu1031
Copy link
Contributor

issue: #39367

@sre-ci-robot sre-ci-robot requested review from chyezh and sunby January 16, 2025 15:35
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 16, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (0461ddf) to head (8c0a730).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39368   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files         300      300           
  Lines       26903    26903           
=======================================
  Hits        18692    18692           
  Misses       8211     8211           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.47% <ø> (ø)
Go ∅ <ø> (∅)

@weiliu1031 weiliu1031 closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants