Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply custom producer config for kafkaHealthCheck #39364

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

DLT1412
Copy link
Contributor

@DLT1412 DLT1412 commented Jan 16, 2025

issue: #39287
pr: #39283

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 16, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DLT1412
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from xige-16 and yhmo January 16, 2025 12:14
Copy link
Contributor

mergify bot commented Jan 16, 2025

@DLT1412 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Jan 16, 2025
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@DLT1412 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (e752059) to head (52adb0d).
Report is 10 commits behind head on 2.5.

Files with missing lines Patch % Lines
pkg/mq/msgstream/msgstream_util.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39364      +/-   ##
==========================================
+ Coverage   80.99%   81.02%   +0.02%     
==========================================
  Files        1404     1404              
  Lines      197531   197535       +4     
==========================================
+ Hits       159999   160052      +53     
+ Misses      31898    31860      -38     
+ Partials     5634     5623      -11     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.50% <ø> (-0.01%) ⬇️
Go 82.99% <40.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
pkg/mq/msgstream/msgstream_util.go 49.42% <40.00%> (-0.58%) ⬇️

... and 36 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 16, 2025
@DLT1412
Copy link
Contributor Author

DLT1412 commented Jan 16, 2025

rerun go-sdk

1 similar comment
@DLT1412
Copy link
Contributor Author

DLT1412 commented Jan 17, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 17, 2025

@DLT1412 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@DLT1412
Copy link
Contributor Author

DLT1412 commented Jan 17, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 17, 2025

@DLT1412 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants