Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phrase match does not support offset input #39338

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

SpadeA-Tang
Copy link
Contributor

fix: #39337

Signed-off-by: SpadeA-Tang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (75d7978) to head (c5c891f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/Types.h 0.00% 3 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39338   +/-   ##
=======================================
  Coverage   81.03%   81.04%           
=======================================
  Files        1407     1407           
  Lines      198527   198530    +3     
=======================================
+ Hits       160885   160893    +8     
+ Misses      31983    31980    -3     
+ Partials     5659     5657    -2     
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.47% <0.00%> (-0.03%) ⬇️
Go 82.99% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/exec/expression/UnaryExpr.h 69.44% <0.00%> (ø)
internal/core/src/common/Types.h 29.80% <0.00%> (-0.44%) ⬇️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 16, 2025
@sre-ci-robot sre-ci-robot merged commit 0461ddf into milvus-io:master Jan 16, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: phrase match should not support offset input
3 participants