-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add unit test for string pk #39329
Conversation
Signed-off-by: sunby <[email protected]>
@sunby cpp-unit-test check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39329 +/- ##
===========================================
+ Coverage 69.65% 81.02% +11.37%
===========================================
Files 299 1408 +1109
Lines 26799 198565 +171766
===========================================
+ Hits 18667 160894 +142227
- Misses 8132 32014 +23882
- Partials 0 5657 +5657
|
Signed-off-by: sunby <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, sunby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#39107