Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add unit test for string pk #39329

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 16, 2025

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (d2834a1) to head (8ed1c1b).
Report is 43 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39329       +/-   ##
===========================================
+ Coverage   69.65%   81.02%   +11.37%     
===========================================
  Files         299     1408     +1109     
  Lines       26799   198565   +171766     
===========================================
+ Hits        18667   160894   +142227     
- Misses       8132    32014    +23882     
- Partials        0     5657     +5657     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.56% <ø> (-0.09%) ⬇️
Go 82.95% <ø> (∅)

see 1131 files with indirect coverage changes

Signed-off-by: sunby <[email protected]>
@mergify mergify bot added the ci-passed label Jan 20, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 140c5a0 into milvus-io:master Jan 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants