Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: optimize delete init construct code #39327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jan 16, 2025

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 16, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 16, 2025
@zhagnlu zhagnlu force-pushed the optimize_delete_init_construct branch from 4f67afd to 16fd795 Compare January 16, 2025 04:05
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (bca2a62) to head (16fd795).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39327       +/-   ##
===========================================
+ Coverage   69.63%   81.07%   +11.43%     
===========================================
  Files         299     1406     +1107     
  Lines       26807   198460   +171653     
===========================================
+ Hits        18668   160907   +142239     
- Misses       8139    31897    +23758     
- Partials        0     5656     +5656     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.64% <94.44%> (+<0.01%) ⬆️
Go 82.99% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/DeletedRecord.h 87.50% <100.00%> (-0.79%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.h 70.11% <100.00%> (+1.06%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 84.11% <100.00%> (+0.04%) ⬆️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.98% <75.00%> (+0.12%) ⬆️

... and 1114 files with indirect coverage changes

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jan 16, 2025

rerun ut

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jan 17, 2025

rerun ut

@mergify mergify bot added the ci-passed label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants