Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance[2.5]: move GetVector_EmptySparseVector ut to growing test #39286

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

zhengbuqian
Copy link
Collaborator

issue: #35853
pr: #39234

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhengbuqian
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 15, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@zhengbuqian

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (5b0bb4c) to head (7597e0f).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39286      +/-   ##
==========================================
- Coverage   81.04%   81.02%   -0.02%     
==========================================
  Files        1400     1400              
  Lines      196950   196950              
==========================================
- Hits       159614   159584      -30     
- Misses      31710    31739      +29     
- Partials     5626     5627       +1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.58% <ø> (ø)
Go 82.97% <ø> (-0.02%) ⬇️

see 23 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. do-not-merge/invalid-pr-format size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants