Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Add scalar index engine version for compatibility #39236

Merged

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Jan 14, 2025

issue: #39203

master pr: #39204

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/internal-api labels Jan 14, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 14, 2025
Copy link
Contributor

mergify bot commented Jan 14, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 95.93023% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (9a63383) to head (35a5fe9).
Report is 10 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/datacoord/index_engine_version_manager.go 88.23% 3 Missing and 1 partial ⚠️
internal/indexnode/indexnode.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39236      +/-   ##
==========================================
- Coverage   81.07%   81.06%   -0.01%     
==========================================
  Files        1394     1399       +5     
  Lines      196509   196774     +265     
==========================================
+ Hits       159313   159518     +205     
- Misses      31595    31650      +55     
- Partials     5601     5606       +5     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.53% <ø> (ø)
Go 83.03% <95.93%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 95.34% <100.00%> (+<0.01%) ⬆️
internal/datacoord/task_index.go 82.70% <100.00%> (+0.07%) ⬆️
internal/indexnode/indexnode_service.go 83.71% <100.00%> (+0.06%) ⬆️
internal/indexnode/task_index.go 71.87% <100.00%> (+1.32%) ⬆️
internal/indexnode/taskinfo_ops.go 81.37% <100.00%> (+0.06%) ⬆️
internal/metastore/model/segment_index.go 95.83% <100.00%> (+0.18%) ⬆️
internal/querynodev2/server.go 77.57% <100.00%> (+0.11%) ⬆️
internal/util/sessionutil/session_util.go 76.65% <100.00%> (+0.73%) ⬆️
pkg/common/common.go 77.18% <ø> (ø)
internal/indexnode/indexnode.go 77.72% <50.00%> (-0.75%) ⬇️
... and 1 more

... and 62 files with indirect coverage changes

Signed-off-by: Cai Zhang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 14, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 14, 2025
@czs007 czs007 self-assigned this Jan 14, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 14, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added this to the 2.5.4 milestone Jan 14, 2025
@sre-ci-robot sre-ci-robot merged commit 4270174 into milvus-io:2.5 Jan 14, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants