-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Record active collections for l0Policy #39217
Conversation
@XuanYang-cn E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39217 +/- ##
===========================================
+ Coverage 69.63% 81.02% +11.38%
===========================================
Files 299 1406 +1107
Lines 26807 198445 +171638
===========================================
+ Hits 18668 160782 +142114
- Misses 8139 31996 +23857
- Partials 0 5667 +5667
|
By recording the active collection lists, The l0 compaction trigger of view change and idle won't influence each other. Also this pr replace the L0View cache with real L0 segments' change. Save some memory and make L0 trigger more accurate. See also: milvus-io#39187 Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
1cad969
to
e3f8f24
Compare
@XuanYang-cn go-sdk check failed, comment |
@XuanYang-cn E2e jenkins job failed, comment |
@XuanYang-cn go-sdk check failed, comment |
@XuanYang-cn E2e jenkins job failed, comment |
@XuanYang-cn go-sdk check failed, comment |
Signed-off-by: yangxuan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR /lgtm but I suppose the compaction_policy_l0.go
implementation could be simpler. Let's refactor it in the later PRs.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tedxu, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
By recording the active collection lists, The l0 compaction trigger of view change and idle won't influence each other. Also this pr replaces the L0View cache with real L0 segments' change. Save some memory and make L0 compaction triggers more accurate. See also: milvus-io#39187 pr: milvus-io#39217 Signed-off-by: yangxuan <[email protected]> --------- Signed-off-by: yangxuan <[email protected]>
By recording the active collection lists, The l0 compaction trigger of view change and idle won't influence each other. Also this pr replaces the L0View cache with real L0 segments' change. Save some memory and make L0 compaction triggers more accurate. See also: milvus-io#39187 pr: milvus-io#39217 Signed-off-by: yangxuan <[email protected]> --------- Signed-off-by: yangxuan <[email protected]>
By recording the active collection lists, The l0 compaction trigger
of view change and idle won't influence each other.
Also this pr replaces the L0View cache with real L0 segments' change.
Save some memory and make L0 compaction triggers more accurate.
See also: #39187
Signed-off-by: yangxuan [email protected]