Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Record active collections for l0Policy #39217

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

XuanYang-cn
Copy link
Contributor

By recording the active collection lists, The l0 compaction trigger
of view change and idle won't influence each other.

Also this pr replaces the L0View cache with real L0 segments' change.
Save some memory and make L0 compaction triggers more accurate.

See also: #39187

Signed-off-by: yangxuan [email protected]

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (bca2a62) to head (16990d8).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/compaction_trigger_v2.go 88.23% 4 Missing ⚠️
internal/datacoord/compaction_policy_l0.go 95.58% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39217       +/-   ##
===========================================
+ Coverage   69.63%   81.02%   +11.38%     
===========================================
  Files         299     1406     +1107     
  Lines       26807   198445   +171638     
===========================================
+ Hits        18668   160782   +142114     
- Misses       8139    31996    +23857     
- Partials        0     5667     +5667     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.64% <ø> (+0.01%) ⬆️
Go 82.93% <93.33%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/services.go 85.67% <100.00%> (ø)
internal/datacoord/task_stats.go 92.62% <100.00%> (ø)
internal/datacoord/compaction_policy_l0.go 96.96% <95.58%> (ø)
internal/datacoord/compaction_trigger_v2.go 68.81% <88.23%> (ø)

... and 1110 files with indirect coverage changes

By recording the active collection lists, The l0 compaction trigger
of view change and idle won't influence each other.

Also this pr replace the L0View cache with real L0 segments' change.
Save some memory and make L0 trigger more accurate.

See also: milvus-io#39187

Signed-off-by: yangxuan <[email protected]>
Copy link
Contributor

mergify bot commented Jan 14, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

image

Signed-off-by: yangxuan <[email protected]>
@mergify mergify bot added the ci-passed label Jan 16, 2025
Copy link
Contributor

@tedxu tedxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR /lgtm but I suppose the compaction_policy_l0.go implementation could be simpler. Let's refactor it in the later PRs.

@tedxu
Copy link
Contributor

tedxu commented Jan 16, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 74b4369 into milvus-io:master Jan 16, 2025
20 checks passed
@XuanYang-cn XuanYang-cn deleted the fix-stale-l0 branch January 17, 2025 02:42
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jan 17, 2025
By recording the active collection lists, The l0 compaction trigger
of view change and idle won't influence each other.

Also this pr replaces the L0View cache with real L0 segments' change.
Save some memory and make L0 compaction triggers more accurate.

See also: milvus-io#39187
pr: milvus-io#39217

Signed-off-by: yangxuan <[email protected]>

---------

Signed-off-by: yangxuan <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jan 17, 2025
By recording the active collection lists, The l0 compaction trigger
of view change and idle won't influence each other.

Also this pr replaces the L0View cache with real L0 segments' change.
Save some memory and make L0 compaction triggers more accurate.

See also: milvus-io#39187
pr: milvus-io#39217

Signed-off-by: yangxuan <[email protected]>

---------

Signed-off-by: yangxuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants