enhance: Unify LoadStateLock RLock & PinIf #39206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
chyezh
reviewed
Jan 13, 2025
|
/lgtm |
|
@congqixia go-sdk check failed, comment |
|
@congqixia E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39206 +/- ##
==========================================
- Coverage 81.16% 81.15% -0.01%
==========================================
Files 1399 1404 +5
Lines 197579 197713 +134
==========================================
+ Hits 160357 160446 +89
- Misses 31593 31638 +45
Partials 5629 5629
|
congqixia
force-pushed
the
enhance/unify_rlock_pinif
branch
from
5b87cec to
9eaa8b3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
chyezh
reviewed
Jan 14, 2025
Related to milvus-io#39205 This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function preventing segment being released before any Read operation finished. Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
congqixia
force-pushed
the
enhance/unify_rlock_pinif
branch
from
9eaa8b3 to
cfda1de
Compare
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 14, 2025
Related to milvus-io#39205 This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function preventing segment being released before any Read operation finished. --------- Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 15, 2025
Related to milvus-io#39205 This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function preventing segment being released before any Read operation finished. --------- Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 15, 2025
Related to milvus-io#39205 Previous PR milvus-io#39206 This PR change wait timeout behavior to log error and return to avoid making other collection read failure in only some collections have deadlock Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 15, 2025
Related to milvus-io#39205 Previous PR milvus-io#39206 This PR change wait timeout behavior to log error and return to avoid making other collection read failure in only some collections have deadlock Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 15, 2025
Related to milvus-io#39205 Previous PR milvus-io#39206 This PR change wait timeout behavior to log error and return to avoid making other collection read failure in only some collections have deadlock Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Cherry-pick from master pr: #39206 #39308 Related to #39205 This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function preventing segment being released before any Read operation finished. --------- --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Cherry-pick from master pr: #39206 #39308 Related to #39205 This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function preventing segment being released before any Read operation finished. --------- --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…9308) Related to #39205 Previous PR #39206 This PR change wait timeout behavior to log error and return to avoid making other collection read failure in only some collections have deadlock Signed-off-by: Congqi Xia <[email protected]>
gifi-siby
pushed a commit
to gifi-siby/milvus
that referenced
this pull request
Jan 16, 2025
Related to milvus-io#39205 This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function preventing segment being released before any Read operation finished. --------- Signed-off-by: Congqi Xia <[email protected]>
gifi-siby
pushed a commit
to gifi-siby/milvus
that referenced
this pull request
Jan 16, 2025
…lvus-io#39308) Related to milvus-io#39205 Previous PR milvus-io#39206 This PR change wait timeout behavior to log error and return to avoid making other collection read failure in only some collections have deadlock Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #39205
This PR merge
RLock&PinIfNotReleasedintoPinIffunction preventing segment being released before any Read operation finished.